refactor IPC (#341)

tests/unit/api-client.test.ts

@@ -0,0 +1,153 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import {
+  invokeIpc,
+  invokeIpcWithRetry,
+  AppError,
+  toUserMessage,
+  configureApiClient,
+  registerTransportInvoker,
+  unregisterTransportInvoker,
+  clearTransportBackoff,
+} from '@/lib/api-client';
+
+describe('api-client', () => {
+  beforeEach(() => {
+    vi.resetAllMocks();
+    configureApiClient({
+      enabled: { ws: false, http: false },
+      rules: [{ matcher: /.*/, order: ['ipc'] }],
+    });
+    clearTransportBackoff();
+    unregisterTransportInvoker('ws');
+    unregisterTransportInvoker('http');
+  });
+
+  it('forwards invoke arguments and returns result', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke.mockResolvedValueOnce({ ok: true, data: { ok: true } });
+
+    const result = await invokeIpc<{ ok: boolean }>('settings:getAll', { a: 1 });
+
+    expect(result.ok).toBe(true);
+    expect(invoke).toHaveBeenCalledWith(
+      'app:request',
+      expect.objectContaining({
+        module: 'settings',
+        action: 'getAll',
+      }),
+    );
+  });
+
+  it('normalizes timeout errors', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke.mockRejectedValueOnce(new Error('Gateway Timeout'));
+
+    await expect(invokeIpc('gateway:status')).rejects.toMatchObject({ code: 'TIMEOUT' });
+  });
+
+  it('retries once for retryable errors', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke
+      .mockResolvedValueOnce({ ok: false, error: { code: 'TIMEOUT', message: 'network timeout' } })
+      .mockResolvedValueOnce({ ok: true, data: { success: true } });
+
+    const result = await invokeIpcWithRetry<{ success: boolean }>('provider:list', [], 1);
+
+    expect(result.success).toBe(true);
+    expect(invoke).toHaveBeenCalledTimes(2);
+  });
+
+  it('returns user-facing message for permission error', () => {
+    const msg = toUserMessage(new AppError('PERMISSION', 'forbidden'));
+    expect(msg).toContain('Permission denied');
+  });
+
+  it('falls back to legacy channel when unified route is unsupported', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke
+      .mockRejectedValueOnce(new Error('APP_REQUEST_UNSUPPORTED:settings.getAll'))
+      .mockResolvedValueOnce({ foo: 'bar' });
+
+    const result = await invokeIpc<{ foo: string }>('settings:getAll');
+    expect(result.foo).toBe('bar');
+    expect(invoke).toHaveBeenNthCalledWith(2, 'settings:getAll');
+  });
+
+  it('sends tuple payload for multi-arg unified requests', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke.mockResolvedValueOnce({ ok: true, data: { success: true } });
+
+    const result = await invokeIpc<{ success: boolean }>('settings:set', 'language', 'en');
+
+    expect(result.success).toBe(true);
+    expect(invoke).toHaveBeenCalledWith(
+      'app:request',
+      expect.objectContaining({
+        module: 'settings',
+        action: 'set',
+        payload: ['language', 'en'],
+      }),
+    );
+  });
+
+  it('falls through ws/http and succeeds via ipc when advanced transports fail', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke.mockResolvedValueOnce({ ok: true, data: { ok: true } });
+
+    registerTransportInvoker('ws', async () => {
+      throw new Error('ws unavailable');
+    });
+    registerTransportInvoker('http', async () => {
+      throw new Error('http unavailable');
+    });
+    configureApiClient({
+      enabled: { ws: true, http: true },
+      rules: [{ matcher: 'gateway:rpc', order: ['ws', 'http', 'ipc'] }],
+    });
+
+    const result = await invokeIpc<{ ok: boolean }>('gateway:rpc', 'chat.history', {});
+    expect(result.ok).toBe(true);
+    expect(invoke).toHaveBeenCalledWith('gateway:rpc', 'chat.history', {});
+  });
+
+  it('backs off failed ws transport and skips it on immediate retry', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke.mockResolvedValue({ ok: true });
+    const wsInvoker = vi.fn(async () => {
+      throw new Error('ws unavailable');
+    });
+
+    registerTransportInvoker('ws', wsInvoker);
+    configureApiClient({
+      enabled: { ws: true, http: false },
+      rules: [{ matcher: 'gateway:rpc', order: ['ws', 'ipc'] }],
+    });
+
+    await invokeIpc('gateway:rpc', 'chat.history', {});
+    await invokeIpc('gateway:rpc', 'chat.history', {});
+
+    expect(wsInvoker).toHaveBeenCalledTimes(1);
+    expect(invoke).toHaveBeenCalledTimes(2);
+  });
+
+  it('retries ws transport after backoff is cleared', async () => {
+    const invoke = vi.mocked(window.electron.ipcRenderer.invoke);
+    invoke.mockResolvedValue({ ok: true });
+    const wsInvoker = vi.fn(async () => {
+      throw new Error('ws unavailable');
+    });
+
+    registerTransportInvoker('ws', wsInvoker);
+    configureApiClient({
+      enabled: { ws: true, http: false },
+      rules: [{ matcher: 'gateway:rpc', order: ['ws', 'ipc'] }],
+    });
+
+    await invokeIpc('gateway:rpc', 'chat.history', {});
+    clearTransportBackoff('ws');
+    await invokeIpc('gateway:rpc', 'chat.history', {});
+
+    expect(wsInvoker).toHaveBeenCalledTimes(2);
+    expect(invoke).toHaveBeenCalledTimes(2);
+  });
+});

tests/unit/feedback-state.test.tsx

@@ -0,0 +1,30 @@
+import { describe, it, expect } from 'vitest';
+import { render, screen } from '@testing-library/react';
+import { FeedbackState } from '@/components/common/FeedbackState';
+
+describe('FeedbackState', () => {
+  it('renders loading state content', () => {
+    render(<FeedbackState state="loading" title="Loading data" description="Please wait" />);
+
+    expect(screen.getByText('Loading data')).toBeInTheDocument();
+    expect(screen.getByText('Please wait')).toBeInTheDocument();
+  });
+
+  it('renders action for empty state', () => {
+    render(
+      <FeedbackState
+        state="empty"
+        title="Nothing here"
+        action={<button type="button">Create one</button>}
+      />,
+    );
+
+    expect(screen.getByRole('button', { name: 'Create one' })).toBeInTheDocument();
+  });
+
+  it('renders error state title', () => {
+    render(<FeedbackState state="error" title="Request failed" />);
+
+    expect(screen.getByText('Request failed')).toBeInTheDocument();
+  });
+});