fix(gateway): make heartbeat observability-only to prevent false cascade restarts (#762)

This commit is contained in:
paisley
2026-04-03 14:50:06 +08:00
committed by GitHub
Unverified
parent 1d2cbf8f26
commit 83f67e1ed3
2 changed files with 48 additions and 29 deletions

View File

@@ -16,7 +16,7 @@ describe('GatewayManager heartbeat recovery', () => {
vi.setSystemTime(new Date('2026-03-19T00:00:00.000Z'));
});
it('terminates stale socket only after 3 consecutive heartbeat misses', async () => {
it('logs warning but does NOT terminate socket after consecutive heartbeat misses', async () => {
const { GatewayManager } = await import('@electron/gateway/manager');
const manager = new GatewayManager();
@@ -39,7 +39,9 @@ describe('GatewayManager heartbeat recovery', () => {
vi.advanceTimersByTime(120_000);
expect(ws.ping).toHaveBeenCalledTimes(3);
expect(ws.terminate).toHaveBeenCalledTimes(1);
// Heartbeat timeout is now observability-only — socket should NOT be terminated.
// Process liveness is detected via child.on('exit'), socket disconnects via ws.on('close').
expect(ws.terminate).not.toHaveBeenCalled();
(manager as unknown as { connectionMonitor: { clear: () => void } }).connectionMonitor.clear();
});