admin/SuperCharged-Claude-Code-Upgrade
1
2
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add Project Roman session fix analysis and design documentation

Browse Source 
This commit includes comprehensive analysis and design documentation
for fixing critical session management issues in manually created projects.

Phase 1 Complete:
- Identified 4 critical errors (SSE null reference, array access,
  race conditions, virtual workingDir mismatch)
- Created detailed root cause analysis
- Designed comprehensive solution with 5 components
- Complete implementation plan with testing strategy

Files added:
- ROMAN_SESSION_ISSUE_ANALYSIS.md - Detailed root cause analysis
- ROMAN_SESSION_FIX_DESIGN.md - Complete solution design
- ROMAN_IMPLEMENTATION_SUMMARY.md - Quick reference guide
- PHASE_1_COMPLETE_REPORT.md - Executive summary

Next: Awaiting AI Engineer review before implementation

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
uroma
2026-01-22 15:19:25 +00:00
Unverified
parent 2d94e81a3f
commit ea7f90519f
7 changed files with 1488 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

86
public/claude-ide/project-manager.js
View File

@@ -25,6 +25,7 @@ class ProjectManager {
this.closedProjects = new Set(); // Track closed project IDs
this.STORAGE_KEY = 'claude_ide_closed_projects';
this.PROJECTS_STORAGE_KEY = 'claude_ide_projects'; // Store manually created projects
this.pendingSessionAdd = null; // Track newly created session to preserve it during loadProjects
}
/**
@@ -138,6 +139,7 @@ class ProjectManager {
/**
* Load all sessions and organize them by project
* CRITICAL FIX: Preserve pending session addition to avoid race condition
*/
async loadProjects() {
try {
@@ -152,6 +154,19 @@ class ProjectManager {
...(data.historical || []).map(s => ({...s, status: 'historical'}))
];
// CRITICAL FIX: Preserve pending session if it exists
// This ensures a newly created session is not lost if API doesn't return it yet
if (this.pendingSessionAdd) {
console.log('[ProjectManager] Preserving pending session:', this.pendingSessionAdd.id.substring(0, 8));
// Check if session is already in the API response
const sessionExists = allSessions.some(s => s.id === this.pendingSessionAdd.id);
if (!sessionExists) {
// Add to allSessions so it gets included in the load
allSessions.unshift(this.pendingSessionAdd);
console.log('[ProjectManager] Added pending session to allSessions:', this.pendingSessionAdd.id.substring(0, 8));
}
}
// Group by working directory
// CRITICAL FIX: Handle virtual projects by adding sessions directly to manually created projects
const virtualSessions = []; // Store sessions with virtual workingDirs
@@ -542,19 +557,45 @@ class ProjectManager {
const data = await res.json();
if (data.success || data.id) {
// CRITICAL FIX: Only call loadProjects() - do NOT call initialize()
// initialize() would reload stale data from localStorage
// CRITICAL FIX: Extract the session object from response
const session = data.session || data;
// CRITICAL FIX: Normalize status to 'active' for consistency
// Backend returns 'running' but frontend expects 'active' or 'historical'
const normalizedSession = {
...session,
status: session.status === 'running' ? 'active' : session.status
};
// CRITICAL FIX: Store pending session to preserve it during loadProjects
this.pendingSessionAdd = normalizedSession;
console.log('[ProjectManager] Session created successfully, adding to project:', normalizedSession.id);
console.log('[ProjectManager] Session data:', {
id: normalizedSession.id,
workingDir: normalizedSession.workingDir,
metadata: normalizedSession.metadata,
status: normalizedSession.status
});
// Add session to project immediately
this.addSessionToProject(normalizedSession);
// CRITICAL FIX: Refresh from API to ensure consistency, but the pending session
// will be preserved if not in API response yet
await this.loadProjects();
this.renderProjectTabs();
// Find the new session and switch to it
const session = data.session || data;
for (const project of this.projects.values()) {
const foundSession = project.sessions.find(s => s.id === session.id);
if (foundSession) {
await this.switchProject(project.id);
break;
}
// Clear pending session after loadProjects completes
this.pendingSessionAdd = null;
// Find the project containing this session and switch to it
const targetProject = this.getProjectForSession(normalizedSession.id);
if (targetProject) {
console.log('[ProjectManager] Found session in project:', targetProject.name);
await this.switchProject(targetProject.id);
} else {
console.warn('[ProjectManager] Could not find project for session:', normalizedSession.id);
}
if (typeof hideLoadingOverlay === 'function') {
@@ -567,6 +608,9 @@ class ProjectManager {
hideLoadingOverlay();
}
// Clear pending session on error
this.pendingSessionAdd = null;
// Special handling for timeout/abort errors
if (error.name === 'AbortError') {
this.showError('Request timed out. The server took too long to respond. Please try again.');
@@ -632,18 +676,32 @@ class ProjectManager {
}
const project = this.projects.get(projectKey);
project.sessions.unshift(session); // Add to beginning
project.activeSessionId = session.id;
console.log('[ProjectManager] Added session', session.id.substring(0, 8), 'to project:', project.name, 'key:', projectKey, 'total sessions:', project.sessions.length);
// Check if session already exists in the project
const existingIndex = project.sessions.findIndex(s => s.id === session.id);
if (existingIndex === -1) {
// Add to beginning (newest first)
project.sessions.unshift(session);
console.log('[ProjectManager] Added session', session.id.substring(0, 8), 'to project:', project.name, 'key:', projectKey, 'total sessions:', project.sessions.length);
} else {
// Move to beginning if already exists
project.sessions.splice(existingIndex, 1);
project.sessions.unshift(session);
console.log('[ProjectManager] Moved existing session', session.id.substring(0, 8), 'to top of project:', project.name);
}
project.activeSessionId = session.id;
// Re-render if this is the active project
if (this.activeProjectId === project.id) {
this.renderProjectTabs();
// CRITICAL FIX: Update left sidebar chat history with this project's sessions
// CRITICAL FIX: Use await to ensure the UI updates before continuing
if (typeof loadChatHistory === 'function') {
loadChatHistory(project.sessions);
loadChatHistory(project.sessions).catch(err => {
console.error('[ProjectManager] Error loading chat history:', err);
});
}
if (window.sessionTabs) {